RNS/Identity.py

@@ -217,7 +217,7 @@ class Identity:
         return Identity.truncated_hash(os.urandom(Identity.TRUNCATED_HASHLENGTH//8))
 
     @staticmethod
-    def validate_announce(packet, only_validate_signature=False):
+    def validate_announce(packet):
         try:
             if packet.packet_type == RNS.Packet.ANNOUNCE:
                 destination_hash = packet.destination_hash
@@ -238,10 +238,6 @@ class Identity:
                 announced_identity.load_public_key(public_key)
 
                 if announced_identity.pub != None and announced_identity.validate(signature, signed_data):
-                    if only_validate_signature:
-                        del announced_identity
-                        return True
-
                     hash_material = name_hash+announced_identity.hash
                     expected_hash = RNS.Identity.full_hash(hash_material)[:RNS.Reticulum.TRUNCATED_HASHLENGTH//8]
 

RNS/Interfaces/AX25KISSInterface.py

@@ -77,7 +77,8 @@ class AX25KISSInterface(Interface):
             RNS.log("You can install one with the command: python3 -m pip install pyserial", RNS.LOG_CRITICAL)
             RNS.panic()
 
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 564
         

RNS/Interfaces/AutoInterface.py

@@ -76,9 +76,11 @@ class AutoInterface(Interface):
 
     def __init__(self, owner, name, group_id=None, discovery_scope=None, discovery_port=None, data_port=None, allowed_interfaces=None, ignored_interfaces=None, configured_bitrate=None):
         from RNS.vendor.ifaddr import niwrapper
-        super().__init__()
         self.netinfo = niwrapper
 
+        self.rxb = 0
+        self.txb = 0
+
         self.HW_MTU = 1064
 
         self.IN  = True

RNS/Interfaces/I2PInterface.py

@@ -390,7 +390,8 @@ class I2PInterfacePeer(Interface):
     TUNNEL_STATE_STALE   = 0x02
 
     def __init__(self, parent_interface, owner, name, target_i2p_dest=None, connected_socket=None, max_reconnect_tries=None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 1064
         
@@ -831,7 +832,8 @@ class I2PInterface(Interface):
     BITRATE_GUESS      = 256*1000
 
     def __init__(self, owner, name, rns_storagepath, peers, connectable = False, ifac_size = 16, ifac_netname = None, ifac_netkey = None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
         
         self.HW_MTU = 1064
 
@@ -962,12 +964,6 @@ class I2PInterface(Interface):
     def processOutgoing(self, data):
         pass
 
-    def received_announce(self, from_spawned=False):
-        if from_spawned: self.ia_freq_deque.append(time.time())
-
-    def sent_announce(self, from_spawned=False):
-        if from_spawned: self.oa_freq_deque.append(time.time())
-
     def detach(self):
         RNS.log("Detaching "+str(self), RNS.LOG_DEBUG)
         self.i2p.stop()

RNS/Interfaces/Interface.py

@@ -23,7 +23,6 @@
 import RNS
 import time
 import threading
-from collections import deque
 
 class Interface:
     IN  = False
@@ -44,65 +43,14 @@ class Interface:
     # should actively discover paths for.
     DISCOVER_PATHS_FOR  = [MODE_ACCESS_POINT, MODE_GATEWAY]
 
-    # How many samples to use for incoming
-    # announce frequency calculation
-    IA_FREQ_SAMPLES     = 6
-    OA_FREQ_SAMPLES     = 6
-
     def __init__(self):
         self.rxb = 0
         self.txb = 0
         self.online = False
-        self.ia_freq_deque = deque(maxlen=Interface.IA_FREQ_SAMPLES)
-        self.oa_freq_deque = deque(maxlen=Interface.OA_FREQ_SAMPLES)
 
     def get_hash(self):
         return RNS.Identity.full_hash(str(self).encode("utf-8"))
 
-    def received_announce(self):
-        self.ia_freq_deque.append(time.time())
-        if hasattr(self, "parent_interface") and self.parent_interface != None:
-            self.parent_interface.received_announce(from_spawned=True)
-
-    def sent_announce(self):
-        self.oa_freq_deque.append(time.time())
-        if hasattr(self, "parent_interface") and self.parent_interface != None:
-            self.parent_interface.sent_announce(from_spawned=True)
-
-    def incoming_announce_frequency(self):
-        if not len(self.ia_freq_deque) > 1:
-            return 0
-        else:
-            dq_len = len(self.ia_freq_deque)
-            delta_sum = 0
-            for i in range(1,dq_len):
-                delta_sum += self.ia_freq_deque[i]-self.ia_freq_deque[i-1]
-            delta_sum += time.time() - self.ia_freq_deque[dq_len-1]
-            
-            if delta_sum == 0:
-                avg = 0
-            else:
-                avg = 1/(delta_sum/(dq_len))
-
-            return avg
-
-    def outgoing_announce_frequency(self):
-        if not len(self.oa_freq_deque) > 1:
-            return 0
-        else:
-            dq_len = len(self.oa_freq_deque)
-            delta_sum = 0
-            for i in range(1,dq_len):
-                delta_sum += self.oa_freq_deque[i]-self.oa_freq_deque[i-1]
-            delta_sum += time.time() - self.oa_freq_deque[dq_len-1]
-            
-            if delta_sum == 0:
-                avg = 0
-            else:
-                avg = 1/(delta_sum/(dq_len))
-
-            return avg
-
     def process_announce_queue(self):
         if not hasattr(self, "announce_cap"):
             self.announce_cap = RNS.Reticulum.ANNOUNCE_CAP
@@ -131,7 +79,6 @@ class Interface:
                     self.announce_allowed_at = now + wait_time
 
                     self.processOutgoing(selected["raw"])
-                    self.sent_announce()
 
                     if selected in self.announce_queue:
                         self.announce_queue.remove(selected)

RNS/Interfaces/KISSInterface.py

@@ -70,7 +70,8 @@ class KISSInterface(Interface):
             RNS.log("You can install one with the command: python3 -m pip install pyserial", RNS.LOG_CRITICAL)
             RNS.panic()
 
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
         
         self.HW_MTU = 564
         

RNS/Interfaces/LocalInterface.py

@@ -53,7 +53,8 @@ class LocalClientInterface(Interface):
     RECONNECT_WAIT = 3
 
     def __init__(self, owner, name, target_port = None, connected_socket=None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         # TODO: Remove at some point
         # self.rxptime = 0
@@ -279,7 +280,8 @@ class LocalClientInterface(Interface):
 class LocalServerInterface(Interface):
 
     def __init__(self, owner, bindport=None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
         self.online = False
         self.clients = 0
         
@@ -336,12 +338,6 @@ class LocalServerInterface(Interface):
     def processOutgoing(self, data):
         pass
 
-    def received_announce(self, from_spawned=False):
-        if from_spawned: self.ia_freq_deque.append(time.time())
-
-    def sent_announce(self, from_spawned=False):
-        if from_spawned: self.oa_freq_deque.append(time.time())
-
     def __str__(self):
         return "Shared Instance["+str(self.bind_port)+"]"
 

RNS/Interfaces/PipeInterface.py

@@ -54,7 +54,8 @@ class PipeInterface(Interface):
         if respawn_delay == None:
             respawn_delay = 5
 
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 1064
         

RNS/Interfaces/RNodeInterface.py

@@ -114,7 +114,8 @@ class RNodeInterface(Interface):
             RNS.log("You can install one with the command: python3 -m pip install pyserial", RNS.LOG_CRITICAL)
             RNS.panic()
 
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 508
         

RNS/Interfaces/SerialInterface.py

@@ -60,7 +60,8 @@ class SerialInterface(Interface):
             RNS.log("You can install one with the command: python3 -m pip install pyserial", RNS.LOG_CRITICAL)
             RNS.panic()
 
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 564
         

RNS/Interfaces/TCPInterface.py

@@ -79,7 +79,8 @@ class TCPClientInterface(Interface):
     I2P_PROBES = 5
 
     def __init__(self, owner, name, target_ip=None, target_port=None, connected_socket=None, max_reconnect_tries=None, kiss_framing=False, i2p_tunneled = False, connect_timeout = None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
         
         self.HW_MTU = 1064
         
@@ -418,7 +419,8 @@ class TCPServerInterface(Interface):
         return ifaddr[netinfo.AF_INET][0]["broadcast"]
 
     def __init__(self, owner, name, device=None, bindip=None, bindport=None, i2p_tunneled=False):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 1064
 
@@ -503,12 +505,6 @@ class TCPServerInterface(Interface):
         self.clients += 1
         spawned_interface.read_loop()
 
-    def received_announce(self, from_spawned=False):
-        if from_spawned: self.ia_freq_deque.append(time.time())
-
-    def sent_announce(self, from_spawned=False):
-        if from_spawned: self.oa_freq_deque.append(time.time())
-
     def processOutgoing(self, data):
         pass
 

RNS/Interfaces/UDPInterface.py

@@ -45,7 +45,8 @@ class UDPInterface(Interface):
         return ifaddr[netinfo.AF_INET][0]["broadcast"]
 
     def __init__(self, owner, name, device=None, bindip=None, bindport=None, forwardip=None, forwardport=None):
-        super().__init__()
+        self.rxb = 0
+        self.txb = 0
 
         self.HW_MTU = 1064
 

RNS/Reticulum.py

@@ -1143,8 +1143,6 @@ class Reticulum:
                 ifstats["name"] = str(interface)
                 ifstats["rxb"] = interface.rxb
                 ifstats["txb"] = interface.txb
-                ifstats["incoming_announce_frequency"] = interface.incoming_announce_frequency()
-                ifstats["outgoing_announce_frequency"] = interface.outgoing_announce_frequency()
                 ifstats["status"] = interface.online
                 ifstats["mode"] = interface.mode
 

RNS/Transport.py

@@ -887,8 +887,6 @@ class Transport:
                         # thread.start()
 
                         Transport.transmit(interface, packet.raw)
-                        if packet.packet_type == RNS.Packet.ANNOUNCE:
-                            interface.sent_announce()
                         sent = True
 
         if sent:
@@ -1229,11 +1227,8 @@ class Transport:
             # announces, queueing rebroadcasts of these, and removal
             # of queued announce rebroadcasts once handed to the next node.
             if packet.packet_type == RNS.Packet.ANNOUNCE:
-                if interface != None and RNS.Identity.validate_announce(packet, only_validate_signature=True):
-                    interface.received_announce()
-
                 local_destination = next((d for d in Transport.destinations if d.hash == packet.destination_hash), None)
-                if local_destination == None and RNS.Identity.validate_announce(packet):
+                if local_destination == None and RNS.Identity.validate_announce(packet): 
                     if packet.transport_id != None:
                         received_from = packet.transport_id
                         

RNS/Utilities/rnstatus.py

@@ -46,7 +46,7 @@ def size_str(num, suffix='B'):
 
     return "%.2f%s%s" % (num, last_unit, suffix)
 
-def program_setup(configdir, dispall=False, verbosity=0, name_filter=None, json=False, astats=False, sorting=None, sort_reverse=False):
+def program_setup(configdir, dispall=False, verbosity=0, name_filter=None,json=False):
     reticulum = RNS.Reticulum(configdir = configdir, loglevel = 3+verbosity)
 
     stats = None
@@ -62,36 +62,16 @@ def program_setup(configdir, dispall=False, verbosity=0, name_filter=None, json=
                 if isinstance(stats[s], bytes):
                     stats[s] = RNS.hexrep(stats[s], delimit=False)
 
-                if isinstance(stats[s], dict):
+                for i in stats[s]:
-                    for i in stats[s]:
+                    if isinstance(i, dict):
-                        if isinstance(i, dict):
+                        for k in i:
-                            for k in i:
+                            if isinstance(i[k], bytes):
-                                if isinstance(i[k], bytes):
+                                i[k] = RNS.hexrep(i[k], delimit=False)
-                                    i[k] = RNS.hexrep(i[k], delimit=False)
 
             print(json.dumps(stats))
             exit()
-
-        interfaces = stats["interfaces"]
-        if sorting != None and isinstance(sorting, str):
-            sorting = sorting.lower()
-            if sorting == "rate" or sorting == "bitrate":
-                interfaces.sort(key=lambda i: i["bitrate"], reverse=not sort_reverse)
-            if sorting == "rx":
-                interfaces.sort(key=lambda i: i["rxb"], reverse=not sort_reverse)
-            if sorting == "tx":
-                interfaces.sort(key=lambda i: i["txb"], reverse=not sort_reverse)
-            if sorting == "traffic":
-                interfaces.sort(key=lambda i: i["rxb"]+i["txb"], reverse=not sort_reverse)
-            if sorting == "announces" or sorting == "announce":
-                interfaces.sort(key=lambda i: i["incoming_announce_frequency"]+i["outgoing_announce_frequency"], reverse=not sort_reverse)
-            if sorting == "arx":
-                interfaces.sort(key=lambda i: i["incoming_announce_frequency"], reverse=not sort_reverse)
-            if sorting == "atx":
-                interfaces.sort(key=lambda i: i["outgoing_announce_frequency"], reverse=not sort_reverse)
-
             
-        for ifstat in interfaces:
+        for ifstat in stats["interfaces"]:
             name = ifstat["name"]
 
             if dispall or not (
@@ -133,7 +113,7 @@ def program_setup(configdir, dispall=False, verbosity=0, name_filter=None, json=
                                 else:
                                     spec_str = " programs"
 
-                                clients_string = "Serving   : "+str(cnum)+spec_str
+                                clients_string = "Serving : "+str(cnum)+spec_str
                             elif name.startswith("I2PInterface["):
                                 if "i2p_connectable" in ifstat and ifstat["i2p_connectable"] == True:
                                     cnum = clients
@@ -142,11 +122,11 @@ def program_setup(configdir, dispall=False, verbosity=0, name_filter=None, json=
                                     else:
                                         spec_str = " connected I2P endpoints"
 
-                                    clients_string = "Peers     : "+str(cnum)+spec_str
+                                    clients_string = "Peers   : "+str(cnum)+spec_str
                                 else:
                                     clients_string = ""
                             else:
-                                clients_string = "Clients   : "+str(clients)
+                                clients_string = "Clients : "+str(clients)
 
                         else:
                             clients = None
@@ -154,50 +134,46 @@ def program_setup(configdir, dispall=False, verbosity=0, name_filter=None, json=
                         print(" {n}".format(n=ifstat["name"]))
 
                         if "ifac_netname" in ifstat and ifstat["ifac_netname"] != None:
-                            print("    Network   : {nn}".format(nn=ifstat["ifac_netname"]))
+                            print("    Network : {nn}".format(nn=ifstat["ifac_netname"]))
 
-                        print("    Status    : {ss}".format(ss=ss))
+                        print("    Status  : {ss}".format(ss=ss))
 
                         if clients != None and clients_string != "":
                             print("    "+clients_string)
 
                         if not (name.startswith("Shared Instance[") or name.startswith("TCPInterface[Client") or name.startswith("LocalInterface[")):
-                            print("    Mode      : {mode}".format(mode=modestr))
+                            print("    Mode    : {mode}".format(mode=modestr))
 
                         if "bitrate" in ifstat and ifstat["bitrate"] != None:
-                            print("    Rate      : {ss}".format(ss=speed_str(ifstat["bitrate"])))
+                            print("    Rate    : {ss}".format(ss=speed_str(ifstat["bitrate"])))
 
                         if "airtime_short" in ifstat and "airtime_long" in ifstat:
-                            print("    Airtime   : {atl}% (1h), {ats}% (15s)".format(ats=str(ifstat["airtime_short"]),atl=str(ifstat["airtime_long"])))
+                            print("    Airtime : {atl}% (1h), {ats}% (15s)".format(ats=str(ifstat["airtime_short"]),atl=str(ifstat["airtime_long"])))
                         
                         if "channel_load_short" in ifstat and "channel_load_long" in ifstat:
-                            print("    Ch.Load   : {atl}% (1h), {ats}% (15s)".format(ats=str(ifstat["channel_load_short"]),atl=str(ifstat["channel_load_long"])))
+                            print("    Ch.Load : {atl}% (1h), {ats}% (15s)".format(ats=str(ifstat["channel_load_short"]),atl=str(ifstat["channel_load_long"])))
                         
                         if "peers" in ifstat and ifstat["peers"] != None:
-                            print("    Peers     : {np} reachable".format(np=ifstat["peers"]))
+                            print("    Peers   : {np} reachable".format(np=ifstat["peers"]))
 
                         if "tunnelstate" in ifstat and ifstat["tunnelstate"] != None:
-                            print("    I2P       : {ts}".format(ts=ifstat["tunnelstate"]))
+                            print("    I2P     : {ts}".format(ts=ifstat["tunnelstate"]))
 
                         if "ifac_signature" in ifstat and ifstat["ifac_signature"] != None:
                             sigstr = "<…"+RNS.hexrep(ifstat["ifac_signature"][-5:], delimit=False)+">"
-                            print("    Access    : {nb}-bit IFAC by {sig}".format(nb=ifstat["ifac_size"]*8, sig=sigstr))
+                            print("    Access  : {nb}-bit IFAC by {sig}".format(nb=ifstat["ifac_size"]*8, sig=sigstr))
                         
                         if "i2p_b32" in ifstat and ifstat["i2p_b32"] != None:
-                            print("    I2P B32   : {ep}".format(ep=str(ifstat["i2p_b32"])))
+                            print("    I2P B32 : {ep}".format(ep=str(ifstat["i2p_b32"])))
 
-                        if astats and "announce_queue" in ifstat and ifstat["announce_queue"] != None and ifstat["announce_queue"] > 0:
+                        if "announce_queue" in ifstat and ifstat["announce_queue"] != None and ifstat["announce_queue"] > 0:
                             aqn = ifstat["announce_queue"]
                             if aqn == 1:
-                                print("    Queued    : {np} announce".format(np=aqn))
+                                print("    Queued  : {np} announce".format(np=aqn))
                             else:
-                                print("    Queued    : {np} announces".format(np=aqn))
+                                print("    Queued  : {np} announces".format(np=aqn))
                         
-                        if astats and "incoming_announce_frequency" in ifstat and ifstat["incoming_announce_frequency"] != None:
+                        print("    Traffic : {txb}↑\n              {rxb}↓".format(rxb=size_str(ifstat["rxb"]), txb=size_str(ifstat["txb"])))
-                            print("    Announces : {iaf}↑".format(iaf=RNS.prettyfrequency(ifstat["outgoing_announce_frequency"])))
-                            print("                {iaf}↓".format(iaf=RNS.prettyfrequency(ifstat["incoming_announce_frequency"])))
-
-                        print("    Traffic   : {txb}↑\n                {rxb}↓".format(rxb=size_str(ifstat["rxb"]), txb=size_str(ifstat["txb"])))
 
         if "transport_id" in stats and stats["transport_id"] != None:
             print("\n Transport Instance "+RNS.prettyhexrep(stats["transport_id"])+" running")
@@ -224,31 +200,6 @@ def main():
             default=False
         )
         
-        parser.add_argument(
-            "-A",
-            "--announce-stats",
-            action="store_true",
-            help="show announce stats",
-            default=False
-        )
-        
-        parser.add_argument(
-            "-s",
-            "--sort",
-            action="store",
-            help="sort interfaces by [traffic, rx, tx, announces, arx, atx, rate]",
-            default=None,
-            type=str
-        )
-        
-        parser.add_argument(
-            "-r",
-            "--reverse",
-            action="store_true",
-            help="reverse sorting",
-            default=False,
-        )
-        
         parser.add_argument(
             "-j",
             "--json",
@@ -268,16 +219,7 @@ def main():
         else:
             configarg = None
 
-        program_setup(
+        program_setup(configdir = configarg, dispall = args.all, verbosity=args.verbose, name_filter=args.filter, json=args.json)
-            configdir = configarg,
-            dispall = args.all,
-            verbosity=args.verbose,
-            name_filter=args.filter,
-            json=args.json,
-            astats=args.announce_stats,
-            sorting=args.sort,
-            sort_reverse=args.reverse,
-        )
 
     except KeyboardInterrupt:
         print("")

RNS/__init__.py

@@ -180,18 +180,6 @@ def prettysize(num, suffix='B'):
 
     return "%.2f%s%s" % (num, last_unit, suffix)
 
-def prettyfrequency(hz, suffix="Hz"):
-    num = hz*1e6
-    units = ["µ", "m", "", "K","M","G","T","P","E","Z"]
-    last_unit = "Y"
-
-    for unit in units:
-        if abs(num) < 1000.0:
-            return "%.2f %s%s" % (num, unit, suffix)
-        num /= 1000.0
-
-    return "%.2f%s%s" % (num, last_unit, suffix)
-
 def prettytime(time, verbose=False):
     days = int(time // (24 * 3600))
     time = time % (24 * 3600)