Tried fixing gdal bullshit in steepnes method

documentation/slides.md

@@ -5,16 +5,31 @@ author:
 - Trygve og Esther
 
 ---
-# What are contours
 
-# Output of our program
-pretty pictures
+# Output of our program:
+![Contour map of Ås](kurver_ås.png)
+
+# Marching squares
+![By Nicoguaro; Adroitwhiz - File:Marching_squares_algorithm.svg, CC BY-SA 4.0, https://commons.wikimedia.org/w/index.php?curid=143418710](ms_wikipedia.svg)
 
 # The logical flow of our program
-flowchart
-
-# GDAL
-What is it?
+```cpp
+int main(int argc, const char* argv[])
+{
+    const char* filepath = argv[1];
+    HeightMap map(filepath); 
+    map.blur(0.8)
+    auto lines = create_lines(&map, 5);
+    write_output_file(cellmaps, "out.geojson", &map);
+}
+```
 
 # Performance
-show the benchmarks
+|                    |       Time         |
+|--------------------|--------------------|
+|  12 threads        |     41s            |
+|   1 thread         |     116s           |
+
+
+# Problems we encountered
+

src/HeightMap.cpp

@@ -1,3 +1,4 @@
+#include <cstddef>
 #include <gdal/cpl_conv.h>
 #include <iostream>
 #include <stdexcept>
@@ -5,7 +6,7 @@
 #include <gdal/gdal.h>
 #include "gdal/gdal_priv.h"
 #include <gdal/gdal_frmts.h>
-
+//#include "matplotlibcpp.h"
 #include "contour_creator.hh"
 
 
@@ -32,6 +33,7 @@ HeightMap::HeightMap(const char* filepath)
     //https://gdal.org/api/gdaldataset_cpp.html#_CPPv4N11GDALDataset15GetGeoTransformEPd
     this->geotransform = (double *) CPLMalloc(sizeof(double)*6);
     this->reference_system = *(file->GetSpatialRef());
+    this->filepath = filepath;
 
     file->GetGeoTransform(this->geotransform);
     
@@ -41,6 +43,7 @@ HeightMap::HeightMap(const char* filepath)
                     0, 0 );
     if (error) { throw std::runtime_error("Could not read tif file!"); }
     band->FlushCache();
+    const int size = this->width*this->height;
 }
 float HeightMap::get_pixel(int x, int y)
 {
@@ -62,7 +65,7 @@ void HeightMap::blur(float standard_deviation)
         *(kernel + i) = 1.0;
     }
 
-    float* blurred = (float *) CPLMalloc(sizeof(float)*this->width*this->height);
+    float* blurred = new float[this->width*this->height];
     #pragma omp parallel
     {
     #pragma omp for
@@ -91,3 +94,100 @@ void HeightMap::blur(float standard_deviation)
     this->data = blurred;
     blurred = nullptr;
 }
+
+void HeightMap::statistics()
+{
+
+    float avg = 0;
+    float var = 0;
+    float std = 0;
+
+    for (int i = 0; i < this->width*this->height; i++)
+        {int x = i%this->width;
+        int y = i/this->width;
+            if (x<0 || x>=this->width)
+            {
+                x = 0;
+            }
+            
+            if (y<0 || y>=this->height)
+            {
+                y = 0;
+            }
+        avg += this->get_pixel(x, y);}
+        //std::cout << this->get_pixel(x, y);}
+    
+    avg = avg/(this->width*this->height);
+    std::cout << "Average value: " << avg <<"\n";
+
+    for (int i = 0; i < this->width*this->height; i++)
+    {
+        int x = i%this->width;
+        int y = i/this->width;
+        var += (avg - this->get_pixel(x, y))*(avg - this->get_pixel(x, y));
+    }
+    std = sqrt(var)/(this->width*this->height-1);
+    var = var / (this->width*this->height-1);
+    std::cout << "std: " << std << "\n";
+    std::cout << "var: " << var << "\n";
+};
+
+
+void HeightMap::calculate_steepness()
+{
+    int kernel_height = 5;
+    int kernel_width = 5;
+    int kernel_size = kernel_height*kernel_width;
+
+    float* kernel = new float[sizeof(float)*kernel_size];
+    float* steepness = new float[this->width*this->height];
+    #pragma omp parallel
+    {
+    #pragma omp for
+    for (int i = 0; i < this->height * this->width; i++)
+    {
+        int x = i%this->width;
+        int y = i/this->width;
+        float max = 0;
+        float min = 0;
+        for (int j = 0; j < kernel_size; j++)
+        {
+            if (this->get_pixel(x, y) > max)
+            {
+                max = get_pixel(x, y);
+            }
+
+            if (this->get_pixel(x, y) < min)
+            {
+                min = get_pixel(x, y);
+            }
+
+            if (x<0 || x>=this->width)
+            {
+                x = 0;
+            }
+            
+            if (y<0 || y>=this->height)
+            {
+                y = 0;
+            }
+            
+        }
+        steepness[i] = max - min;
+    }
+    }
+    GDALAllRegister();
+    GDALDataset *original_file = (GDALDataset *) GDALOpen( filepath, GA_ReadOnly );
+
+    const char * filename = "steepness.tif";
+    auto driver = GetGDALDriverManager()->GetDriverByName("GeoRaster");
+    GDALDataset *file;
+    file = driver->CreateCopy("steepness.tif", original_file, FALSE, NULL, NULL, NULL);
+
+    file->AddBand(GDT_Float32, NULL);
+    GDALRasterBand *band = file->GetRasterBand(0);
+    CPLErr error = band->RasterIO( GF_Write, 0, 0, this->width, this->height,
+                    steepness, this->width, this->height, GDT_Float32,
+                    0, 0 );
+    GDALClose(file);
+}

src/contour_creator.hh

@@ -16,10 +16,12 @@ class HeightMap
         float min; //!< Minimum value in image
         float max; //!< Maximum value in image
         OGRSpatialReference reference_system;
-
         HeightMap(const char* filepath);
+        const char* filepath;
         float get_pixel(int x,int y);
         void blur(float standard_deviation);
+        void statistics();
+        void calculate_steepness();
 };
 
 /**
@@ -43,13 +45,10 @@ class Point
         int x;
         int y;
         int mscase;
-        Point * next;
-        Point * previous;
+        bool allocated = false;
         Point(int x, int y, int mscase){
             this -> x = x;
             this -> y = y;
             this -> mscase = mscase;
-            this -> next = nullptr;
-            this -> previous = nullptr;
         };
 };

src/main.cpp

@@ -5,7 +5,6 @@
 #include <gdal/ogr_feature.h>
 #include <gdal/ogr_geometry.h>
 #include <iostream>
-#include <iterator>
 #include <ostream>
 #include <vector>
 #include <cstdint>
@@ -13,6 +12,8 @@
 #include "gdal/gdal_priv.h"
 #include <gdal/gdal_frmts.h>
 #include <omp.h>
+//#include "matplotlibcpp.h"
+//namespace plt = matplotlibcpp;
 
 std::vector<Point> produce_cellmap(HeightMap* heightmap, float z)
 {
@@ -22,28 +23,21 @@ std::vector<Point> produce_cellmap(HeightMap* heightmap, float z)
     for (int i = 0; i<length; i++) {
         int y = i/(heightmap->width-1);
         int x = i%(heightmap->width-1);
-        uint8_t result = (heightmap->get_pixel(x,y)>z) + 
-        (heightmap->get_pixel(x+1,y)>z)*2 +
-        (heightmap->get_pixel(x+1,y+1)>z)*4 +
-        (heightmap->get_pixel(x,y+1)>z)*8;
+        uint8_t result = (heightmap->get_pixel(x,y)>z)*8 + 
+        (heightmap->get_pixel(x+1,y)>z)*4 +
+        (heightmap->get_pixel(x+1,y+1)>z)*2 +
+        (heightmap->get_pixel(x,y+1)>z);
         if (result != 0 and result != 15 ) {
             points.push_back(Point(x, y, result));
-
         };
     }
-    
     return points;
-
-
 }
 
-
-
-std::vector<std::vector<Point>> vector_cellmap(HeightMap* heightmap, int interval)
+std::vector<std::vector<Point>> create_lines(HeightMap* heightmap, int interval)
 {
     int num_contours = (heightmap->max - heightmap->min)/interval;
     std::vector<std::vector<Point>> vector_contours;
-    omp_set_num_threads(12);
 
     #pragma omp parallel
     {
@@ -52,27 +46,67 @@ std::vector<std::vector<Point>> vector_cellmap(HeightMap* heightmap, int interva
         for (int i = 1; i <= num_contours; i++) 
         {
             auto points = produce_cellmap(heightmap, heightmap->min + interval*i);
-
-                
+            std::vector<Point> line;
+            int x;
+            int y;
+            int points_allocated = 0;
+            x = points[0].x;
+            y = points[0].y;
+            points[0].allocated = true;
+            line.push_back(points[0]);
             for (int j = 0; j < points.size(); j++){
-                Point current = points[j];
-                //std::cout << points_allocated << " " << points.size() << "\n";
                 for (int k = 0; k < points.size(); k++){
-                    Point candidate = points[k];
-                    if (candidate.next != nullptr) {
-                        if (candidate.x +1 == current.x) {
-                            current.next = &candidate;
+                    Point* candidate = &points[k];
+                    if (!candidate->allocated) {
+                        if (candidate->x == x +1 && candidate->y == y) {
+                            candidate->allocated = true;
+                            x = candidate->x;
+                            y = candidate->y;
+                            line.push_back(*candidate);
+                            points_allocated++;
+                            break;
                         }
-                        else if (candidate.x -1 == current.x) {
-                            current.next = &candidate;
+                        else if (candidate->x == x -1 && candidate->y == y) {
+                            x = candidate->x;
+                            y = candidate->y;
+                            candidate->allocated = true;
+                            line.push_back(*candidate);
+                            points_allocated++;
+                            break;
                         }
-                        else if (candidate.y +1 == current.x) {
-                            current.next = &candidate;
+                        else if (candidate->x == x && candidate->y == y + 1) {
+                            x = candidate->x;
+                            y = candidate->y;
+                            candidate->allocated = true;
+                            line.push_back(*candidate);
+                            points_allocated++;
+                            break;
                         }
-                        else if (candidate.y -1 == current.x) {
-                            current.next = &candidate;
+                        else if (candidate->x == x && candidate->y == y - 1) {
+                            x = candidate->x;
+                            y = candidate->y;
+                            candidate->allocated = true;
+                            line.push_back(*candidate);
+                            points_allocated++;
+                            break;
+                        }
+                    }
+                }
+                if (j > points_allocated)
+                {
+                    vec_private.push_back(line);
+                    line.clear();
+                    //std::cout << points.size() << " ";
+                    for (int k = 0; k < points.size(); k++){
+                        Point* candidate = &points[k];
+                        if (!candidate->allocated)
+                        {
+                            line.push_back(*candidate);
+                            x = candidate->x;
+                            y = candidate->y;
+                            points_allocated++;
+                            break;
                         }
-                        
                     }
                 }
             }
@@ -80,7 +114,6 @@ std::vector<std::vector<Point>> vector_cellmap(HeightMap* heightmap, int interva
         #pragma omp critical
 
         vector_contours.insert(vector_contours.end(), vec_private.begin(), vec_private.end());
-
     }
         return vector_contours;
 }
@@ -100,7 +133,7 @@ constexpr std::tuple<double, double, double, double> marching_squares_lookup(int
     switch (mcase) {
         case 1: return {0, 0.5, 0.5, 0};
         case 2: return {1, 0.5, 0.5, 0};
-        case 3: return {0, 0.5, 1, 0};
+        case 3: return {0, 0.5, 1, 0.5};
         case 4: return {0.5, 1, 1, 0.5};
         case 5: return {0, 0, 0, 0}; //FIXME
         case 6: return {0.5, 1, 0.5, 0};
@@ -140,7 +173,7 @@ void write_output_file(std::vector<std::vector<Point>> all_points, const char *f
 
     OGRLayer *poLayer;
 
-    poLayer = poDS->CreateLayer( "contours", /*&(cellmaps[0]).reference_system*/ NULL, wkbLineString, NULL );
+    poLayer = poDS->CreateLayer( "contours", &heightmap->reference_system, wkbLineString, NULL );
     if( poLayer == NULL )
     {
         printf( "Layer creation failed.\n" );
@@ -162,49 +195,35 @@ void write_output_file(std::vector<std::vector<Point>> all_points, const char *f
 
     for (int j = 0; j < all_points.size(); j++)
     {
-            OGRFeature *feature;
-            OGRLineString *geometry = new OGRLineString();
-            feature = OGRFeature::CreateFeature( poLayer->GetLayerDefn() );
-            feature->SetField( "Name", j );
-
+        OGRFeature *feature;
+        OGRLineString *geometry = new OGRLineString();
+        feature = OGRFeature::CreateFeature( poLayer->GetLayerDefn() );
+        feature->SetField( "Name", j );
 
         std::vector<Point> points = all_points[j];
 
-        for (int i = 0; i < points.size(); i++) 
+        for (int k = 0; k < points.size(); k++)
         {
-
-            //int x_raw = i%width;
-            //int y_raw = i/height;
-            int x_raw = points[i].x;
-            int y_raw = points[i].y;
+            int x_raw = points[k].x;
+            int y_raw = points[k].y;
             auto [x, y] = local_to_projected(heightmap->geotransform, x_raw, y_raw);
             //auto [x_bl, y_bl, x_tr, y_tr] = marching_squares_lookup(*(cellmap->cells + i) );
-            //std::cout << x << ", " << y << "  ";
-            //geometry->setPoint( geometry->getNumPoints(), x+x_tr*0.25, y+y_tr*0.25 ); 
-            //geometry->setPoint( geometry->getNumPoints(), x+x_bl*0.25, y+y_bl*0.25 ); 
             geometry->setPoint(geometry->getNumPoints(),x ,y );
-
-
-                
-            
         }
 
-                    if ( feature->SetGeometry(geometry) != OGRERR_NONE)
-            {
-                printf( "Failed to set geometry.\n" );
-                exit( 1 );
-            }
-            OGRGeometryFactory::destroyGeometry(geometry);
-            if( poLayer->CreateFeature( feature ) != OGRERR_NONE )
-            {
-                printf( "Failed to create feature in shapefile.\n" );
-                exit( 1 );
-            }
-            OGRFeature::DestroyFeature( feature );  
-        
-
+        if ( feature->SetGeometry(geometry) != OGRERR_NONE)
+        {
+            printf( "Failed to set geometry.\n" );
+            exit( 1 );
+        }
+        OGRGeometryFactory::destroyGeometry(geometry);
+        if( poLayer->CreateFeature( feature ) != OGRERR_NONE )
+        {
+            printf( "Failed to create feature in shapefile.\n" );
+            exit( 1 );
+        }
+        OGRFeature::DestroyFeature( feature );
     }
-
     GDALClose( poDS );
 }
 
@@ -218,8 +237,17 @@ int main(int argc, const char* argv[])
 
     map.blur(0.8);
 
-    auto cellmap = produce_cellmap(&map, 40);
+    map.statistics();
 
-    auto cellmaps = vector_cellmap(&map, 5);
-    write_output_file(cellmaps, "out.geojson", &map);
+    map.calculate_steepness();
+    
+    auto lines = create_lines(&map, 5);
+    write_output_file(lines, "out.geojson", &map);
+
+
+    std::vector<int> y = {1, 2, 3};
+    //plt::plot(y, "bo-");
+    //plt::show();
+
+    return 0;
 }